https://github.com/labath commented:
I see the bitfield handling is reflected in the test case, but I don't see anything about handling of synthetic children or objc pointers. For the objc case, I'm very tempted to *not* copy that bit of code over, since it: a) is untested (or you wouldn't have been able to start using the new implementation); b) doesn't fit into our concept of being language-agnostic. It looks like that's mainly error handling code guarding a call to GetSyntheticArrayMember. That function eventually calls `GetCompilerType().GetChildCompilerTypeAtIndex`, so I think that special handling of ObjC should happen there. That would also reduce the maze of the if statements, which is making the function hard to review. https://github.com/llvm/llvm-project/pull/151605 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
