https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/151291
When running the lldb-rpc-gen tests On Darwin platforms, the sysroot needs to
be added to the test invocation. Without it, basic includes will not be
resolved and the test will fail.
>From 12c4a6aafcbcf171f17843fa2b1695722e98fbda Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova <chelsea_cassan...@apple.com>
Date: Wed, 30 Jul 2025 00:56:06 -0700
Subject: [PATCH] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation
When running the lldb-rpc-gen tests On Darwin platforms, the sysroot
needs to be added to the test invocation. Without it, basic includes
will not be resolved and the test will fail.
---
lldb/test/Shell/helper/toolchain.py | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/lldb/test/Shell/helper/toolchain.py
b/lldb/test/Shell/helper/toolchain.py
index 728f6347242f1..e3bf3123d3c94 100644
--- a/lldb/test/Shell/helper/toolchain.py
+++ b/lldb/test/Shell/helper/toolchain.py
@@ -119,6 +119,16 @@ def use_lldb_substitutions(config):
lldb_init = _get_lldb_init_path(config)
+ if platform.system() in ["Darwin"]:
+ try:
+ out = subprocess.check_output(["xcrun", "--show-sdk-path"]).strip()
+ res = 0
+ except OSError:
+ res = -1
+ if res == 0 and out:
+ sdk_path = lit.util.to_string(out)
+ sysroot_arg = sdk_path
+
primary_tools = [
ToolSubst(
"%lldb",
@@ -163,6 +173,7 @@ def use_lldb_substitutions(config):
extra_args=[
"-p " + config.lldb_build_directory + "/..",
'--extra-arg="-resource-dir=' + config.clang_resource_dir +
'"',
+ '--extra-arg="--sysroot=' + sysroot_arg + '"',
],
unresolved="ignore",
),
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
