santhoshe447 wrote: > This patch still only recognizes the `xqci` from the ELF file and adds it to > the disassembly flags (v. ObjectFileELF::GetSectionHeaderInfo, > ObjectFileELF::ParseRISCVAttributes). > > Is this the only attribute that can be set via this mechanism? is it possible > for other attributes to be specified? The code as written today ignores any > attribute present except for xqci and only adds xqci to the attributes. I'm a > little mystified by a generic sounding approach to picking up ISA extensions > from the binary file, but only handling this one.
Yes, the current implementation focuses only on recognizing the "xqci" attribute, as that's the specific feature I am targeting right now. However, the framework is designed to be generic can handle other RISC-V ELF attributes as well. We can extend it over time to detect and append additional attributes as needed. Since I don't have the full list of features at this point, I have limited the handling to xqci for now, but it's definitely structured for future expansion. Please share anything I can do better here. https://github.com/llvm/llvm-project/pull/147990 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
