clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
If we can add a comment around "bndcfgu" where we use an SBData since it is a
vector register and SBValue::GetValueAsUnsigned(...) won't work because it is a
vector that would be nice for people to know. Other than that this is good to
go!
================
Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:293-294
+
+ lldb::SBData bndcfgu_data = bndcfgu_val.GetData();
+ bndcfgu = bndcfgu_data.GetUnsignedInt64(error, 0);
+ if (!error.Success()) {
----------------
Might be nice to comment that we need to use SBData because this is a vector
register.
https://reviews.llvm.org/D29078
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
