Author: Wanyi Date: 2025-07-18T01:14:28-04:00 New Revision: de453e86977adf4f418b003b5c25931b8365c9cc
URL: https://github.com/llvm/llvm-project/commit/de453e86977adf4f418b003b5c25931b8365c9cc DIFF: https://github.com/llvm/llvm-project/commit/de453e86977adf4f418b003b5c25931b8365c9cc.diff LOG: [lldb-dap] Fix type req->arguments == "disconnect" (#149446) This typo was introduced in PR #140331. This branch will never get executed. We also set the `disconnecting = true` in the `DAP::Disconnect()` so I am not sure if we need it in both places. Added: Modified: lldb/tools/lldb-dap/DAP.cpp Removed: ################################################################################ diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp index fd89f52595ec6..cbd3b14463e25 100644 --- a/lldb/tools/lldb-dap/DAP.cpp +++ b/lldb/tools/lldb-dap/DAP.cpp @@ -983,7 +983,7 @@ llvm::Error DAP::Loop() { if (const protocol::Request *req = std::get_if<protocol::Request>(&*next); - req && req->arguments == "disconnect") + req && req->command == "disconnect") disconnecting = true; const std::optional<CancelArguments> cancel_args = _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
