bulbazord wrote: > > The new code duplicates a lot of the existing logic in API/CMakeLists.txt. > > Wouldn't it be simpler to add the framework code to the existing loop > > behind if(LLDB_BUILD_FRAMEWORK)? > > That can be done, I think we'd also have to move the top-level targets for > fixing up framework headers to that file behind that if-gate as well.
Let's do that then. As-is, I have a hard time reasoning about the differences and overlaps between the logic you're modifying and the logic in `source/API/CMakeLists.txt`. https://github.com/llvm/llvm-project/pull/148736 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
