Nerixyz wrote: > Appreciate the effort to support both PDB _and_ DWARF, but I don't think we > should be jumping through hoops to support PDB when there is no bots running > the API tests for it. It's too easy for that to bit-rot. So I would suggest > dropping PDB support from this for now.
My main intention with supporting PDB was that it's the default debug format (and the only supported one on MSVC). > Or put another way, @Nerixyz how do you make sure PDB is being used when you > run these tests? I run them manually. So this is mostly a best-effort. > If PDB could be added as one of the debug info test types, like we have for > Dwarf and dysym and DWO, that could be added to existing builders. That could work - though some tests would probably need to be skipped. The default should still be DWARF on Windows. One thing to keep in mind is that there are two PDB implementations, the DIA SDK one and the native one. Just today I noticed that they demangle types slightly different - DIA demangles to `std::basic_string<char,std::char_traits<char>,std::allocator<char> >` whereas the native implementation (using LLVM's demangling) demangles to `std::basic_string<char, std::char_traits<char>, std::allocator<char>>` (notice the spaces). This causes some formatters to not match on the types because they check for `^std::foo<.+> >(( )?&)?$`. Other than that, the native one is usually better, from what I can tell. https://github.com/llvm/llvm-project/pull/148554 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
