https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/148956
The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which [targets](https://github.com/llvm/llvm-project/blob/42d2ae1034b287eb60563c370dbf52c59b66db20/lldb/source/Plugins/ABI/CMakeLists.txt#L7) are enabled in the cmake build configuration. This PR updates the test to check for the json object file instead which should be enabled on all builds. >From 304d21e3ae6395f5e966424741c036026c193e6d Mon Sep 17 00:00:00 2001 From: David Peixotto <p...@meta.com> Date: Tue, 15 Jul 2025 13:43:08 -0700 Subject: [PATCH] [lldb] Fix plugin test to not rely on enabled targets The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which [targets](https://github.com/llvm/llvm-project/blob/42d2ae1034b287eb60563c370dbf52c59b66db20/lldb/source/Plugins/ABI/CMakeLists.txt#L7) are enabled in the cmake build configuration. This PR updates the test to check for the json object file instead which should be enabled on all builds. --- lldb/test/API/commands/plugin/TestPlugin.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lldb/test/API/commands/plugin/TestPlugin.py b/lldb/test/API/commands/plugin/TestPlugin.py index e7de7a3f797f1..bd8ab9604538e 100644 --- a/lldb/test/API/commands/plugin/TestPlugin.py +++ b/lldb/test/API/commands/plugin/TestPlugin.py @@ -82,10 +82,10 @@ def test_completions(self): ) # A completion for a full namespace should contain the plugins in that namespace. - self.completions_contain("plugin list abi", ["abi.sysv-x86_64"]) - self.completions_contain("plugin list abi.", ["abi.sysv-x86_64"]) - self.completions_contain("plugin list abi.s", ["abi.sysv-x86_64"]) - self.completions_contain("plugin list abi.sysv-x", ["abi.sysv-x86_64"]) + self.completions_contain("plugin list object-file", ["object-file.JSON"]) + self.completions_contain("plugin list object-file.", ["object-file.JSON"]) + self.completions_contain("plugin list object-file.J", ["object-file.JSON"]) + self.completions_contain("plugin list object-file.JS", ["object-file.JSON"]) # Check for a completion that is a both a complete namespace and a prefix of # another namespace. It should return the completions for the plugins in the completed _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
