DavidSpickett wrote: This is the relevant part of the standard, correct?
``` 7.5.5 Classes and Forms 18 • stroffsetsptr 19 This is an offset into the .debug_str_offsets section 20 (DW_FORM_sec_offset). It consists of an offset from the beginning of the 21 .debug_str_offsets section to the beginning of the string offsets 22 information for the referencing entity. It is relocatable in a relocatable object 23 file, and relocated in an executable or shared object file. In the 32-bit 24 DWARF format, this offset is a 4-byte unsigned value; in the 64-bit DWARF 25 format, it is an 8-byte unsigned value (see Section 7.4 on page 196). ``` (https://dwarfstd.org/doc/DWARF5.pdf) I see also "7.4 32-Bit and 64-Bit DWARF Formats", is there anything else in there we need to handle? (I don't know enough to guess the effects of getting those wrong) I'm also going to run the test suite and see what fails. The baseline is dwarf32: ``` LLDB_TEST_USER_ARGS -E;\"-gdwarf32\" ******************** Failed Tests (5): lldb-api :: commands/frame/language/TestGuessLanguage.py lldb-api :: functionalities/multiple-slides/TestMultipleSlides.py lldb-api :: functionalities/step-avoids-no-debug/TestStepNoDebug.py lldb-api :: lang/c/conflicting-symbol/TestConflictingSymbol.py lldb-api :: lang/cpp/incomplete-types/members/TestCppIncompleteTypeMembers.py ``` All of these manipulate debug info flags, so this is expected. Now DWARF64 current main branch: ``` LLDB_TEST_USER_ARGS -E;\"-gdwarf64\" Total Discovered Tests: 33363 Skipped : 1 (0.00%) Unsupported : 518 (1.55%) Passed : 32273 (96.73%) Expectedly Failed: 31 (0.09%) Unresolved : 12 (0.04%) Timed Out : 1 (0.00%) Failed : 527 (1.58%) ``` A lot of failures, and I had to kill some tests. Could be the way I'm passing the argument, but if so, I'd expect more failures in the baseline. Running tests on your PR right now. https://github.com/llvm/llvm-project/pull/147054 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
