abidh accepted this revision.
abidh added a comment.
Looks good.
================
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22
{
- int a = 10;
+ int a = 10;
+
----------------
This declaration looks redundant.
================
Comment at: tools/lldb-mi/MICmdCmdMiscellanous.cpp:515
+ return MIstatus::failure;
}
----------------
aetf wrote:
> abidh wrote:
> > It is not really an OutofBand record but rather an output of the command.
> > Why not simple add prepend an ~
> The output of the command should be a Stream record which is an OutofBand
> record according to the spec [1]. I agree it's no more than prepending '~'
> and quoting the string. But why not just do what the spec says? ;-)
>
> [1]
> https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Stream-Records.html#GDB_002fMI-Stream-Records
ok.
https://reviews.llvm.org/D24711
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
