================
@@ -581,19 +581,19 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
EmplaceSafeString(object, "name", frame_name);
- auto target = frame.GetThread().GetProcess().GetTarget();
- auto source = CreateSource(frame.GetPCAddress(), target);
+ lldb::SBTarget target = frame.GetThread().GetProcess().GetTarget();
+ protocol::Source source = CreateSource(frame);
+
if (!IsAssemblySource(source)) {
// This is a normal source with a valid line entry.
- auto line_entry = frame.GetLineEntry();
+ lldb::SBLineEntry line_entry = frame.GetLineEntry();
object.try_emplace("line", line_entry.GetLine());
- auto column = line_entry.GetColumn();
+ uint32_t column = line_entry.GetColumn();
----------------
felipepiovezan wrote:
Ah, I see that the `source` one is different.
In general, please move NFC changes to their own separate patches, to avoid
throwing reviewers off.
https://github.com/llvm/llvm-project/pull/143644
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
