================
@@ -847,8 +847,15 @@ bool fromJSON(const llvm::json::Value &Params,
DisassembledInstruction &DI,
}
llvm::json::Value toJSON(const DisassembledInstruction &DI) {
- llvm::json::Object result{{"address", "0x" + llvm::utohexstr(DI.address)},
- {"instruction", DI.instruction}};
+ llvm::json::Object result{{"instruction", DI.instruction}};
+ if (DI.address == LLDB_INVALID_ADDRESS) {
+ // VSCode has explicit comparisons to the string "-1" in order to check for
----------------
JDevlieghere wrote:
Nit: `VS Code` not `VSCode`.
```suggestion
// VS Code has explicit comparisons to the string "-1" in order to check for
```
https://github.com/llvm/llvm-project/pull/141463
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
