[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

[Alex Langford via lldb-commits]

================
@@ -2393,62 +2329,54 @@ lldb::addr_t SBTarget::GetStackRedZoneSize() {
 bool SBTarget::IsLoaded(const SBModule &module) const {
   LLDB_INSTRUMENT_VA(this, module);
 
-  TargetSP target_sp(GetSP());
-  if (!target_sp)
-    return false;
-
-  ModuleSP module_sp(module.GetSP());
-  if (!module_sp)
-    return false;
-
-  return module_sp->IsLoadedInTarget(target_sp.get());
+  if (TargetSP target_sp = GetSP()) {
+    ModuleSP module_sp(module.GetSP());
+    if (module_sp)
+      return module_sp->IsLoadedInTarget(target_sp.get());
+  }
+  return false;
 }
 
 lldb::SBLaunchInfo SBTarget::GetLaunchInfo() const {
   LLDB_INSTRUMENT_VA(this);
 
   lldb::SBLaunchInfo launch_info(nullptr);
-  TargetSP target_sp(GetSP());
-  if (target_sp)
+  if (TargetSP target_sp = GetSP())
     launch_info.set_ref(m_opaque_sp->GetProcessLaunchInfo());
   return launch_info;
 }
 
 void SBTarget::SetLaunchInfo(const lldb::SBLaunchInfo &launch_info) {
   LLDB_INSTRUMENT_VA(this, launch_info);
 
-  TargetSP target_sp(GetSP());
-  if (target_sp)
+  if (TargetSP target_sp = GetSP())
     m_opaque_sp->SetProcessLaunchInfo(launch_info.ref());
 }
 
 SBEnvironment SBTarget::GetEnvironment() {
   LLDB_INSTRUMENT_VA(this);
-  TargetSP target_sp(GetSP());
 
-  if (target_sp) {
+  if (TargetSP target_sp = GetSP())
     return SBEnvironment(target_sp->GetEnvironment());
-  }
 
   return SBEnvironment();
 }
 
 lldb::SBTrace SBTarget::GetTrace() {
   LLDB_INSTRUMENT_VA(this);
-  TargetSP target_sp(GetSP());
 
-  if (target_sp)
+  if (TargetSP target_sp = GetSP())
     return SBTrace(target_sp->GetTrace());
 
   return SBTrace();
 }
 
 lldb::SBTrace SBTarget::CreateTrace(lldb::SBError &error) {
   LLDB_INSTRUMENT_VA(this, error);
-  TargetSP target_sp(GetSP());
-  error.Clear();
 
-  if (target_sp) {
+  error.Clear();
+  if (TargetSP target_sp = GetSP()) {
+    error.Clear();
----------------
bulbazord wrote:

The second clear is unnecessary

https://github.com/llvm/llvm-project/pull/141284
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits