JDevlieghere wrote:

I haven't looked at the code yet. I was re-reading the launch sequence part of 
the spec [1] to make sure this still complies, and I believe it does because 
the spec talks about _responding_ to the request, not about _handling_ it. 

> After the response to configurationDone is sent, the debug adapter may 
> respond to the launch or attach request, and then the debug session has 
> started.

That said, does this actually solve the underlying problems? We know that VS 
Code sends the launch and attach request before configuration done. It's 
equally valid to not do that, and do things the way they're shown in the 
sequence diagram, where you set breakpoints, then configuration done, then 
launch or attach. Won't that still hit the same problem? 

[1] https://microsoft.github.io/debug-adapter-protocol/overview

https://github.com/llvm/llvm-project/pull/140299
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to