jasonmolenda wrote: Also while initially working on this issue I found I could fix it in two places in `SavedLocationForRegister` without considering the entirety of the method. This made me unhappy so I spent a bit of time going over all of `SavedLocationForRegister` until I felt confident I understood it, and then wrote the scariest NFC patch where I removed chunks of it (that are doing nothing) and restructured it so it was a lot easier to read, I thought. But I want to maybe bring that up separately because it's a lot of change and this method has a lot of edge cases - many tricky to test, and not tested well.
https://github.com/llvm/llvm-project/pull/138805 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
