labath wrote: Including a random file from the libc++ subproject sounds like a bad idea to me. I certainly hope we don't have a precedent for that.
For the way you're using these files (as a gtest unit test), I think it'd be best if the tests were in `llvm/include/llvm/Testing/Demangle`. That would most likely be a problem for libc++ since they don't want to depend on llvm (even the demangler is copied into the llvm tree instead of being reused somehow). According to [this](https://github.com/llvm/llvm-project/blob/f62f36b91de684ddfe129532e3a5086009b16f34/libcxxabi/src/demangle/README.txt#L57), it *might* be possible to move the test to llvm and then you could do what I suggest. I don't know what's the amount of wishful thinking in that comment though... Just a note, that if you do decide to copy the tests, it may be better to just copy the inputs (mangled) and then compare the "normal" demangled names with the ones you reconstructed. This avoids needing to update two places in case e.g. the demangler produces extra spaces somewhere. https://github.com/llvm/llvm-project/pull/137793 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
