================ @@ -430,17 +430,20 @@ class ScopesRequestHandler : public LegacyRequestHandler { void operator()(const llvm::json::Object &request) const override; }; -class SetVariableRequestHandler : public LegacyRequestHandler { +class SetVariableRequestHandler final ---------------- ashgti wrote:
Probably my lack of c++ knowledge, but what impact does changing this to `final` have? Should we update all our handlers to be final? https://github.com/llvm/llvm-project/pull/137803 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits