Author: Michael Buch Date: 2025-04-25T11:25:59+01:00 New Revision: da14f6d4b9d8c2b1fde37cd766688ce5e26b2984
URL: https://github.com/llvm/llvm-project/commit/da14f6d4b9d8c2b1fde37cd766688ce5e26b2984 DIFF: https://github.com/llvm/llvm-project/commit/da14f6d4b9d8c2b1fde37cd766688ce5e26b2984.diff LOG: [lldb] Fix MangledTest build failure No equality operator was specified. Define one locally. Added: Modified: lldb/unittests/Core/MangledTest.cpp Removed: ################################################################################ diff --git a/lldb/unittests/Core/MangledTest.cpp b/lldb/unittests/Core/MangledTest.cpp index e903cadd410f3..7dfd4b2a81f9b 100644 --- a/lldb/unittests/Core/MangledTest.cpp +++ b/lldb/unittests/Core/MangledTest.cpp @@ -321,6 +321,14 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) { EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod)); } +static bool NameInfoEquals(const DemangledNameInfo &lhs, + const DemangledNameInfo &rhs) { + return std::tie(lhs.BasenameRange, lhs.ArgumentsRange, lhs.ScopeRange, + lhs.QualifiersRange) == + std::tie(rhs.BasenameRange, rhs.ArgumentsRange, rhs.ScopeRange, + rhs.QualifiersRange); +} + TEST(MangledTest, DemangledNameInfo_SetMangledResets) { Mangled mangled; EXPECT_EQ(mangled.GetDemangledInfo(), std::nullopt); @@ -339,7 +347,7 @@ TEST(MangledTest, DemangledNameInfo_SetMangledResets) { ASSERT_NE(info2, std::nullopt); EXPECT_TRUE(info2->hasBasename()); - EXPECT_NE(info1.value(), info2.value()); + EXPECT_FALSE(NameInfoEquals(info1.value(), info2.value())); EXPECT_EQ(mangled.GetDemangledName(), "func()"); } @@ -375,11 +383,12 @@ TEST(MangledTest, DemangledNameInfo_SetValue) { mangled.SetValue(ConstString("_Z3foov")); auto demangled_foo = mangled.GetDemangledInfo(); EXPECT_NE(demangled_foo, std::nullopt); - EXPECT_NE(demangled_foo, demangled_func); + EXPECT_FALSE(NameInfoEquals(demangled_foo.value(), demangled_func.value())); // SetValue(demangled) resets demangled-info mangled.SetValue(ConstString("_Z4funcv")); - EXPECT_EQ(mangled.GetDemangledInfo(), demangled_func); + EXPECT_TRUE(NameInfoEquals(mangled.GetDemangledInfo().value(), + demangled_func.value())); // SetValue(empty) resets demangled-info mangled.SetValue(ConstString()); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
