> On Nov 7, 2016, at 8:20 AM, Zachary Turner <ztur...@google.com> wrote: > > Why not?
It breaks my build. If the right solution is to fix the unit test, we should advertise somewhere that '-DLLVM_TARGETS_TO_BUILD=X86' is temporarily broken and drop this patch. I'd volunteer to put something like that in place. > Just because llvm isn't building support for targeting some architecture > doesn't mean lldb shouldn't be able to debug those architectures. We could > add a similar LLDB specific define, but using llvm's seems wrong Given 'LLVM_TARGETS_TO_BUILD', how do I define 'LLDB_SUPPORTED_TARGETS'? Do you know of an existing define I can use? thanks, vedant > > On Sun, Nov 6, 2016 at 6:13 PM Vedant Kumar via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > vsk created this revision. > vsk added a reviewer: jasonmolenda. > vsk added a subscriber: lldb-commits. > Herald added a subscriber: mgorny. > > Should fix: https://llvm.org/bugs/show_bug.cgi?id=30928 > > > https://reviews.llvm.org/D26338 > > Files: > unittests/UnwindAssembly/CMakeLists.txt > unittests/UnwindAssembly/InstEmulation/CMakeLists.txt > > > Index: unittests/UnwindAssembly/InstEmulation/CMakeLists.txt > =================================================================== > --- unittests/UnwindAssembly/InstEmulation/CMakeLists.txt > +++ unittests/UnwindAssembly/InstEmulation/CMakeLists.txt > @@ -1 +1,3 @@ > -add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp) > +if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD) > + add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp) > +endif() > Index: unittests/UnwindAssembly/CMakeLists.txt > =================================================================== > --- unittests/UnwindAssembly/CMakeLists.txt > +++ unittests/UnwindAssembly/CMakeLists.txt > @@ -1,2 +1,5 @@ > -add_subdirectory(x86) > +if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD) > + add_subdirectory(x86) > +endif() > + > add_subdirectory(InstEmulation) > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
