labath added a comment.

I've renamed to folder into elf-core and put "linux" into the individual file 
names. I did not rename `TestLinuxCore.py` as I am still not sure what to do 
about it -- if we end up having a lot of these tests, we may want a separate 
`TestFreeBSDCore.py`, with the common code refactored into a base class.

I think you should be able to add a basic freebsd core file test, based on the 
existing main.c. We'll refactor this change after that (PS: Dimitar's 
internship is over, so I may end up taking this over).



================
Comment at: 
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:107
 
+    @skipIf(oslist=['windows'])
+    @skipIf(triple='^mips')
----------------
emaste wrote:
> Curious, why are these skipped only on windows?
My guess would be that we fail to select the correct platform instance when 
opening the core there, so we end up trying to debug a linux core file with 
PlatformWindows, or something like that. I'll need to look into that at some 
point.


https://reviews.llvm.org/D26300



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to