jimingham wrote:

This looks pretty good to me.  I had one trivial doc comment, and I think it's 
better not to start sprinkling internal debugging commands into the lldb 
command set.  The debugger has enough commands already, I like to avoid adding 
ones that nobody but us will ever use.
If we start needing to do this a lot, then we should probably follow gdb and 
add a "maintenance" command to gather them all up.  That way normal user would 
just have to overlook one top-level command.  But in this case, we already have 
`process status` so the debugging dump would fit naturally as an option to that 
command.

https://github.com/llvm/llvm-project/pull/129092
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to