https://github.com/clayborg commented:
I do like the ability to enable/disable any plug-in, but we should only add support for enabling and disabling plug-ins that are optional. This patch adds the ability to enable/disable system runtime plug-ins so that is good. A few things to think about: Do we want a separate command for this, or should we do this with "settings set"? It might make more sense to enable this via the "settings set" command and "settings show" command, but that doesn't allow for us to see ordering of the plug-ins. We already have a manual setting for "plugin.jit-loader.gdb.enable", but this should be a template for how we do enabling and disabling of plug-ins: ``` (lldb) settings set plugin.jit-loader.gdb.enable false (lldb) settings set plugin.system-runtime.macosx.enable false (lldb) settings set plugin.object-file.elf.enable false (lldb) settings set plugin.object-file.pe-coff.enable false ``` The "SystemRuntimeMacOSX" currently has its name set to "systemruntime-macosx", but it should just be "macosx". The above are just for showing how it could look, we may not want to enable/disable object file plug-ins, but maybe we do... So we could do the enable/disable via "settings set" if that makes more sense? Having a separate command for listing the plug-ins does allow ordering to be displayed, so maybe that is preferable? Or maybe we add just the "plugins list" command so we can show the ordering, but set the enabled/disabled state via "settings set"? The nice thing about having dedicated commands, it allows us to enable or disable all plug-ins in a plug-in namespace with one command and as new plug-ins get added, they can be disabled. If we use the "settings set" to enable/disable, then we lose this ability unless we have a category setting that would allow us to enable/disable all plug-ins in a namespace. For example: ``` (lldb) settings set plugin.jit-loader.enable = false ``` This could enable/disable all plug-ins in a namespace using a setting that we would add? @JDevlieghere @jimingham let us know your thoughts? https://github.com/llvm/llvm-project/pull/134418 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
