================ @@ -2233,6 +2233,40 @@ size_t Process::ReadMemoryFromInferior(addr_t addr, void *buf, size_t size, return bytes_read; } +size_t Process::ReadMemoryInChunks(lldb::addr_t vm_addr, DataBufferHeap &data, ---------------- clayborg wrote:
There is no need to pass in a DataBufferHeap into this API. The API should just take the chunk size as a parameter: ``` size_t Process::ReadMemoryInChunks(lldb::addr_t vm_addr, lldb::addr_t vm_size, lldb::addr_t chunk_size, ReadMemoryChunkCallback callback); ``` Then you can create a local DataBufferHeap object in this function outside of the loop that reads the chunks, so the same buffer gets re-used. https://github.com/llvm/llvm-project/pull/129307 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
