https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/133824
These tests are currently filtered on macOS if your on an M1 (or newer) device.
These tests do work on macOS, for me at least on M1 Max with macOS 15.3.2 and
Xcode 16.2.
Enabling them again, but if we have CI problems with them we can keep them
disabled.
>From 191b4dadc4a639d945b9eeda61b4b366ef85ad8f Mon Sep 17 00:00:00 2001
From: John Harrison <harj...@google.com>
Date: Mon, 31 Mar 2025 16:22:57 -0700
Subject: [PATCH] [lldb-dap] Enable runInTerminal tests on macOS.
These tests are currently filtered on macOS if your on an M1 (or newer) device.
These tests do work on macOS, for me at least.
Enabling them again, but if we have CI problems with them we can keep them
disabled.
---
.../restart/TestDAP_restart_runInTerminal.py | 4 ++--
.../runInTerminal/TestDAP_runInTerminal.py | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git
a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py
b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py
index 5a9938c25c2c8..a94c9860c1508 100644
--- a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py
+++ b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py
@@ -21,7 +21,7 @@ def isTestSupported(self):
return False
@skipIfWindows
- @skipIf(archs=["arm"]) # Always times out on buildbot
+ @skipIf(oslist=["linux"], archs=["arm"]) # Always times out on buildbot
def test_basic_functionality(self):
"""
Test basic restarting functionality when the process is running in
@@ -61,7 +61,7 @@ def test_basic_functionality(self):
)
@skipIfWindows
- @skipIf(archs=["arm"]) # Always times out on buildbot
+ @skipIf(oslist=["linux"], archs=["arm"]) # Always times out on buildbot
def test_stopOnEntry(self):
"""
Check that stopOnEntry works correctly when using runInTerminal.
diff --git
a/lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
b/lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
index 9141565ac1b9b..9aab7ca3293db 100644
--- a/lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
+++ b/lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
@@ -44,7 +44,7 @@ def isTestSupported(self):
return False
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminal(self):
if not self.isTestSupported():
return
@@ -90,7 +90,7 @@ def test_runInTerminal(self):
env = self.dap_server.request_evaluate("foo")["body"]["result"]
self.assertIn("bar", env)
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminalWithObjectEnv(self):
if not self.isTestSupported():
return
@@ -114,7 +114,7 @@ def test_runInTerminalWithObjectEnv(self):
self.assertEqual("BAR", request_envs["FOO"])
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminalInvalidTarget(self):
if not self.isTestSupported():
return
@@ -133,7 +133,7 @@ def test_runInTerminalInvalidTarget(self):
)
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_missingArgInRunInTerminalLauncher(self):
if not self.isTestSupported():
return
@@ -148,7 +148,7 @@ def test_missingArgInRunInTerminalLauncher(self):
)
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
if not self.isTestSupported():
return
@@ -175,7 +175,7 @@ def
test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
self.assertIn("No such file or directory", stderr)
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
if not self.isTestSupported():
return
@@ -202,7 +202,7 @@ def
test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
self.assertIn("foo", stdout)
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
if not self.isTestSupported():
return
@@ -223,7 +223,7 @@ def
test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
self.assertIn("FOO=BAR", stdout)
@skipIfWindows
- @skipIf(archs=no_match(["x86_64"]))
+ @skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_NonAttachedRunInTerminalLauncher(self):
if not self.isTestSupported():
return
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
