labath wrote:

I'm not sure what has changed. This code has been here since 2022, so I suspect 
it's one of those "perfectly reasonable" changes I mentioned earlier.

That said, I don't think this code should be here (and I think Alex would 
agree). It should probably go into some kind of a plugin. We have the ability 
to add new commands from (some) plugins. Their names tend to be rather long, 
but that's okay since this appears to be a internal/debugging command. 
@kastiglione, WDYT?

Another way to attack this would be to remove the 
SystemLifetimeManager->Debugger dependency. I'm not quite sure what it does, 
but it shouldn't be here because lldb-server does not need the Debugger. It 
might be possible to move this into `SystemInitializerFull`. I'm also not sure 
if this will help you, as I expect something else will pull in the Debugger 
object anyway.

(and of course, there's always the refactoring I mentioned previously)

https://github.com/llvm/llvm-project/pull/132274
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to