clayborg wrote: Just a quick comment here for this: ``` /// Get if the symbol file for this module is loaded. bool IsDebugInfoLoaded() const; ``` This isn't clear what it is returning. What it seems like it should be returning from the name is "are there debug symbols in this module. But what is actually exposed should be more like: ``` /// Return true if the debug symbols are fully enabled. /// /// Symbols on demand might end up disabling debug info until /// a query is made that requires debug information from this module /// and this function will return false if debug information has been /// disabled in this way. bool IsDebugInfoEnabled() const; ``` The new API added as is seems like we are saying "is there some debug info in the symbol file". But this will always return true unless symbols on demand is restricting debug info access.
If we have a "a.out" binary that has no debug info, it will have a "SymbolFileSymtab" and with no debug info and it will return true because it has a symbol file and it isn't restricted by symbols on demand. Can we revert this and switch to my above suggestion if everyone agrees? https://github.com/llvm/llvm-project/pull/134163 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
