[Lldb-commits] [lldb] [lldb] Combine disassembler gtest binaries for efficiency (PR #133539)

[Alex Langford via lldb-commits]

================
@@ -1,11 +1,32 @@
+set(disas_srcs "")
+
 if("ARM" IN_LIST LLVM_TARGETS_TO_BUILD)
-  add_subdirectory(ARM)
+  set(disas_srcs ${disas_srcs}
----------------
bulbazord wrote:

Suggestion: use `list(APPEND disas_srcs ...)` to more clearly express the 
intent that you're collecting a list of source files.

This one would be:
```
list(APPEND disas_srcs
    ARM/TestArm64Disassembly.cpp
    ARM/TestArmv7Disassembly.cpp
)
```

https://github.com/llvm/llvm-project/pull/133539
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits