abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.

I have a quick look and it seems ok. Apart from fixing the issue, it is a 
useful clean up too. If testcases are ok then please free to commit.

If you have noted that a function (AddSlashes?) is not longer needed after this 
then you may like to remove that too.



================
Comment at: tools/lldb-mi/MICmnMIValueConst.cpp:48
+    m_strValue = CMIUtilString::Format("\"%s\"",
+                                       m_strPartConst.Escape(true).c_str());
   } else {
----------------
So the Escape call here makes sure that we are escaping in all cases.


Repository:
  rL LLVM

https://reviews.llvm.org/D26124



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to