labath wrote: I think the granularity is fine. You should add/modify a test to check that the sections are being parsed correctly. (if there's something missing for that to work, feel free to add it).
I don't have an issue with adding support for 32-bit. I think it's up to you and whether you want to support it. Since llvm::XCOFFObjectFile has separate APIs for accessing 32- and 64-bit versions of the file, probably the easiest way to achieve that is to make any code which depends on that be a template function, which can them be instantiated for the right bitness. https://github.com/llvm/llvm-project/pull/131304 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
