labath added a comment.

I am not that excited by this, but I don't see a much better way to achieve the 
result. :)
 Possibly I'd consider making the variable name positive (instead of 
CFLAGS_NO_DEBUG, have a INCLUDES var, and then the test can use `$(INCLUDES) 
$(TRIPLE_CFLAGS)`).



================
Comment at: Python/lldbsuite/test/make/Makefile.rules:197
-ifeq "$(OS)" "Darwin"
-       CFLAGS += $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES) $(CFLAGS_EXTRAS) 
-I$(LLDB_BASE_DIR)include
-else
----------------
Are you sure this won't actually be missed on darwin for other tests? 
`-archi386` does not seem to be a valid argument to clang (you need the space 
here).


https://reviews.llvm.org/D25922



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to