labath wrote:

The test really is big and splitting it up is a good idea, but instead of an 
arbitrary 1/2/3 split, I think it be better to do it by functionality. Looking 
at the part of the code you moved, I can see several "themes" that we could use 
to split this up. One of them is "memory operations" (TestGdbRemoteMemory?) 
where we could put all of the memory and qMemoryRegionInfo tests. Another might 
be "qSupported" tests. And a third test for the register operations (`p`/`P` 
packets).

If that doesn't reduce the file sufficiently, I'm sure we can find some more.

https://github.com/llvm/llvm-project/pull/129614
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to