https://github.com/DavidSpickett commented:
Been a bit since I looked at this series, so I think "base files" means enough to get a build and you'll come back and implement the specifics later. In that context, mostly small comments other than, I think some of these methods should return failure or error values to prevent you forgetting to update them later. A string error "Implement me!" is fine for the short term. https://github.com/llvm/llvm-project/pull/118160 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
