================
@@ -65,7 +66,7 @@ DAP::DAP(std::string name, llvm::StringRef path, 
std::ofstream *log,
          lldb::IOObjectSP input, lldb::IOObjectSP output, ReplMode repl_mode,
          std::vector<std::string> pre_init_commands)
     : name(std::move(name)), debug_adapter_path(path), log(log),
-      input(std::move(input)), output(std::move(output)),
+      transport(this->name, std::move(input), std::move(output)),
----------------
vogelsgesang wrote:

should we remove `DAP::name` and instead add `const std::string& 
GetClientName() const { return transport->getName(); }`? Then we would store 
this string only once instead of twice, and would have a single source-of-truth

https://github.com/llvm/llvm-project/pull/130026
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to