================
@@ -73,9 +100,50 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr<llvm::telemetry::Config> m_config;
+ // Each instance of a TelemetryManager is assigned a unique ID.
+ const std::string m_id;
----------------
labath wrote:
Putting the generation code into the UUID class seems reasonable. I'm fairly
ambivalent about the storage format. One reason for storing it in the UUID form
might be if we think that someone could be interested in storing/transmitting
the UUID in a binary form (because it's more compact?).
(One thing complicating that is the fact that you're currently appending the
timestamp to the string. I don't think that's necessary because the random data
should be unique enough, and the (unlikely) case of a missing random source
could be handled by initializing a pseudo-random generator with the timestamp
and then using *that* to generate a UUID)
https://github.com/llvm/llvm-project/pull/127696
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
