[Lldb-commits] [lldb] [LLDB][Save Core Options] Custom ranges should follow the same safety checks as everyone else (PR #125323)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 
6a97897d5c159a52975bac19ac22c7913672c549...8bbb150ad7c7ed044d7ca30c745734938263b2d3
 
lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- TestProcessSaveCoreMinidump.py      2025-02-03 18:44:39.000000 +0000
+++ TestProcessSaveCoreMinidump.py      2025-02-03 18:53:56.546684 +0000
@@ -654,18 +654,24 @@
             options.SetOutputFile(lldb.SBFileSpec(output_file))
             options.SetStyle(lldb.eSaveCoreCustomOnly)
             region_one = lldb.SBMemoryRegionInfo()
             process.GetMemoryRegions().GetMemoryRegionAtIndex(0, region_one)
             options.AddMemoryRegionToSave(region_one)
-            empty_region = lldb.SBMemoryRegionInfo("empty region", 0x0, 0x0, 
3, True, False)
+            empty_region = lldb.SBMemoryRegionInfo(
+                "empty region", 0x0, 0x0, 3, True, False
+            )
             options.AddMemoryRegionToSave(empty_region)
-            region_with_no_permissions = lldb.SBMemoryRegionInfo("no 
permissions", 0x2AAA, 0x2BBB, 0, True, False)
+            region_with_no_permissions = lldb.SBMemoryRegionInfo(
+                "no permissions", 0x2AAA, 0x2BBB, 0, True, False
+            )
             options.AddMemoryRegionToSave(region_with_no_permissions)
             error = process.SaveCore(options)
             self.assertTrue(error.Success(), error.GetCString())
             core_target = self.dbg.CreateTarget(None)
             core_process = core_target.LoadCore(output_file)
-            self.assertNotIn(region_with_no_permissions, 
core_process.GetMemoryRegions())
+            self.assertNotIn(
+                region_with_no_permissions, core_process.GetMemoryRegions()
+            )
             self.assertNotIn(empty_region, core_process.GetMemoryRegions())
         finally:
             if os.path.isfile(output_file):
                 os.unlink(output_file)

``````````

</details>


https://github.com/llvm/llvm-project/pull/125323
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits