================ @@ -25,13 +25,10 @@ #include <sstream> #ifdef __ANDROID__ ---------------- brad0 wrote:
> (getgrgid() has been around forever, though, so if anyone cared they could > reduce the scope of this. but probably just `#if defined(__ANDROID__) && > (__ANDROID_API__ >= 24)` is clearer, and groups aren't particularly > meaningful on android anyway, so probably no-one cares in the meantime?) I guess I was wondering if with another diff it would make sense to check the Android API or a comment making it clear when it would make sense to remove. Either way.. https://github.com/llvm/llvm-project/pull/124047 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits