ted accepted this revision.
ted added a comment.
This revision is now accepted and ready to land.

The problem this scenario has is asynchronous output from 2 different sources. 
The original fix made Windows (or any lldb without libedit) much better, but I 
think most non-Windows builds will use libedit, because it's extremely useful. 
lldb-mi has a different set of constraints; the position of the prompt isn't as 
important, since users won't use it as a cue to tell when the debugger can 
accept more input.

Since this improves lldb-mi, and only hurts a use case I think is not very 
prevalent (LLDB_DISABLE_LIBEDIT on a non-Windows platform), I think it's OK. 
LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D25137



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to