https://github.com/DavidSpickett commented:
I don't know if you have worked on LLVM before but regardless, thank you for making use of the nice error handling patterns we have. Even if sometimes they're a bit too much. I don't have any major problems with this, just some style points and a couple of things that need better explanations. https://github.com/llvm/llvm-project/pull/118160 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits