https://github.com/weliveindetail commented:
Yes, I believe there was a condition like that in my patch that introduced the check. And then I simplified it. So, now the problem is that FreeBSD has both, make and gmake, and when we pick up make, the tests fail right? Wouldn't it be sufficient to change the order? ``` find_program(LLDB_DEFAULT_TEST_MAKE gmake make) ``` The only difference to your proposed change is that it would silently pick up make on the BSDs if gmake isn't found (like today). However, it shows an issue that is a concern actually: Do we really want to prefer gmake over make on all platforms? Not sure which platforms actually have it, but it feels incorrect. Why not do something like this? ``` if (FreeBSD or NetBSD) find_program(LLDB_DEFAULT_TEST_MAKE gmake) else() find_program(LLDB_DEFAULT_TEST_MAKE make gmake) endif() ``` https://github.com/llvm/llvm-project/pull/119573 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
