JDevlieghere wrote:

@Jlalond If it were up to me I'd create another PR which adds the 
internal/external property. All existing progress events would be internal so 
that should be NFC. We have unit tests for the progress events so you could 
create an external progress event and test that it's only broadcast to the new 
bit. Then I'd rebase this PR on top and make the progress event created through 
the SB API as external, update the default event handler to listen for the new 
bit in `Debugger.cpp` (which I guess could be part of the first PR too) and 
write a simple API test that creates a progress events and listens for the new 
bit as well, to make sure that doesn't regress at the SB API level. 

https://github.com/llvm/llvm-project/pull/119052
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to