wangleiat wrote: > The test failures were caused by: > > ``` > virtual bool ValidateWatchpoint(size_t size, lldb::addr_t &addr) = 0; > ``` > > Which is actually trying to change size for AArch64, but it's passed by copy > so it wasn't being updated in the caller. See my comments on those lines. > > With that fixed, the test suite passes. > > If you address that, I'll test this again. If it's all working then you can > address @SixWeining 's style suggestions from the original PR, and I'll have > a few of my own.
Thanks very much for your comments. If nothing was missed, everything should be fixed. https://github.com/llvm/llvm-project/pull/118043 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
