Jlalond wrote:

> The build succeeded!
> 
> The source comment at line 82 caught my attention, though. It may imply that 
> data layout is important in this struct, i.e. it should match `siginfo_t` 
> returned by the OS. But this change is not guaranteeing that.
> 
> Actually, the order of the first 3 integers do change on different systems.
> 
> With that said, this LGTM considering that data layout doesn't need to match 
> the OS' `siginfo_t`.

I'll look into fixing the comment, but I'm going to merge to unbreak everyone's 
builds!

https://github.com/llvm/llvm-project/pull/117604
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to