labath wrote: > I'm not expert, but everything looks rigorous and you've added a lot of > comments. > > I left a few nits and a singular question. I would encourage comments on some > file descriptors for the less knowledgeable of us (namely me!)
That you for the review. Making sure the code is understandable to the uninitiated is an important part of it. https://github.com/llvm/llvm-project/pull/115197 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
