clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few naming requests.
================
Comment at: source/Core/Debugger.cpp:151
@@ +150,3 @@
+ "\"caret-only\" mode was selected."},
+ {eStopShowColumnAnsiOnly, "ansi-only",
+ "Highlight the stop column with ANSI terminal codes when running LLDB with "
----------------
Make this "ansi" instead of "ansi-only"?
================
Comment at: source/Core/Debugger.cpp:154
@@ +153,3 @@
+ "color/ANSI enabled."},
+ {eStopShowColumnCaretOnly, "caret-only",
+ "Highlight the stop column with a caret character (^) underneath the stop "
----------------
Make this "caret" instead?
================
Comment at: source/Core/Debugger.cpp:199
@@ +198,3 @@
+ "mark the current position when displaying a stopped context."},
+ {"stop-show-column-decorator-pre", OptionValue::eTypeFormatEntity, true, 0,
+ DEFAULT_STOP_COLUMN_FORMAT_PRE, nullptr,
----------------
Make this "stop-show-column-ansi-prefix"?
================
Comment at: source/Core/Debugger.cpp:204
@@ +203,3 @@
+ "immediately before the column to be marked."},
+ {"stop-show-column-decorator-post", OptionValue::eTypeFormatEntity, true,
0,
+ DEFAULT_STOP_COLUMN_FORMAT_POST, nullptr,
----------------
Make this "stop-show-column-ansi-suffix"?
https://reviews.llvm.org/D20835
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
