================
@@ -71,7 +71,7 @@ int Declaration::Compare(const Declaration &a, const 
Declaration &b) {
 }
 
 bool Declaration::FileAndLineEqual(const Declaration &declaration) const {
-  int file_compare = FileSpec::Compare(this->m_file, declaration.m_file, true);
+  int file_compare = FileSpec::Compare(this->m_file, declaration.m_file, 
false);
----------------
jimingham wrote:

I was using it in a context where the source location being compared came from 
outside - and so potentially had no directory specified since we don't ever 
require users to type full paths.  So false was a necessary option for that use.

The only other use was pulling FileSpec's from debug info, so both sides were 
going to have full paths in them.  Passing full as false doesn't mean ignore 
directories, it just means treat empty directories as `.*`, so true and false 
were equivalent in that case.

But if this bugs you, I'll just add a `full` parameter to 
Declaration::FileAndLineEqual and pipe it through appropriately.

https://github.com/llvm/llvm-project/pull/112939
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to