Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.

Great fix. Just fix the testing so that it isn't ARM specific. There shouldn't 
be any:

  if self.getArchitecture() in ['arm']:
    do arm stuff
  else:
    do non arm stuff

Also we will need to be able to test the set watch at 0x1000, then at 0x1001 by 
sharing, clear 0x1000 make sure 0x1001 still works, etc.


https://reviews.llvm.org/D24610



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits