medismailben wrote:

> > I agree with that, but the argument here was going the other way. 
> > lldb-enumerations.h are a base set of enumerations that anybody using LLDB, 
> > either lldb_private or the SB API's are free to use. But the SB API's are 
> > purely wrappers around lldb_private API's, and so should never be used in 
> > lldb_private. If you put an SB API header in lldb-enumerations.h, now most 
> > of lldb_private is going to see it. Does that also fit wth your mental 
> > model? Jim
> 
> Generally no, though I kind of think the enumeration shouldn't belong in the 
> API directory to begin with. I see Ismail changed that so it seems like we're 
> on the same page here.

+1, may be there was a limitation explaining why it was put in the API tree but 
I didn't bump any issue in https://github.com/llvm/llvm-project/pull/111929. 
May be @adrian-prantl has some more context with regard to that ?

https://github.com/llvm/llvm-project/pull/111907
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to