Michael137 wrote:

Hmm seems like we can't currently run `dotest-param='--category'` on the API 
test suite because of the simulator tests:
```
 File 
"/home/runner/_work/llvm-project/llvm-project/lldb/packages/Python/lldbsuite/test/test_result.py",
 line 183, in startTest
    self.hardMarkAsSkipped(test)
  File 
"/home/runner/_work/llvm-project/llvm-project/lldb/packages/Python/lldbsuite/test/test_result.py",
 line 162, in hardMarkAsSkipped
    getattr(test, test._testMethodName).__func__.__unittest_skip__ = True
AttributeError: 'functools.partial' object has no attribute '__func__'. Did you 
mean: '__doc__'?
```

Looks like the mechanism by which we mark tests skipped doesn't work for the 
partial methods we construct for the `libcxx-simulators`. Even unwrapping the 
`functools.partial` method (or adding a separate `categories` file), will 
silently run these tests. One option would be to add 
`--filter-out=libcxx-simulators` to the lit-invocation. @labath are you 
familiar enough with the `unittest` python library to know how to properly mark 
these simulator tests skipped?

https://github.com/llvm/llvm-project/pull/110856
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to