================
@@ -327,8 +327,6 @@ def test_relative_module_name(self):
         old_cwd = os.getcwd()
         self.addTearDownHook(lambda: os.chdir(old_cwd))
         os.chdir(self.getBuildDir())
-        name = "file-with-a-name-unlikely-to-exist-in-the-current-directory.so"
----------------
labath wrote:

Yes, but this change looks like it defeats the purpose of the test. from the 
looks of things, this test is deliberately checking that the placeholder module 
is created despite the fact that the CWD contains a (bogus) file with that name 
-- you could confirm that by looking at the patch which introduced the change.

That said, I'm very surprised that this change makes a difference for this 
test, since we aren't using the dynamic linker plugin for minidumps (yet). Can 
you explain that?

https://github.com/llvm/llvm-project/pull/110885
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to