labath added a comment.
I have to admit I have very little knowledge of this part of the code. Could
you provide a bit of a high-level overview of this change? Does this fix an
existing problem ? (If so, should it have a test?) Or is it just a refactor?
================
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:12
@@ -11,1 +11,3 @@
+#include <cpuid.h>
+
----------------
Please include the system header last.
================
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:187
@@ +186,3 @@
+// Codes for register sets.
+enum { gpr, fpu, avx, mpx };
+
----------------
I like the short names, but let's make this an `enum class`, so the names don't
leak into the global namespace.
https://reviews.llvm.org/D24559
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
